Adding float16 and bfloat16 support #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @tedxu! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉 |
tedxu
force-pushed
the
feature/add_bf16_support
branch
from
636b95a
to
4c6ccce
Compare
sre-ci-robot
added
size/XXL
tedxu
force-pushed
the
feature/add_bf16_support
branch
from
4c6ccce
to
42fcd3a
Compare
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
tedxu
force-pushed
the
feature/add_bf16_support
branch
from
42fcd3a
to
fa4eb6d
Compare
sre-ci-robot
added
size/XL
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #664 +/- ##
==========================================
- Coverage 73.41% 71.94% -1.47%
==========================================
Files 47 49 +2
Lines 4352 4566 +214
==========================================
+ Hits 3195 3285 +90
- Misses 1043 1167 +124
Partials 114 114
|
congqixia
reviewed
Feb 18, 2024
Comment on lines
+221
to
+224
| if field.DataType == entity.FieldTypeFloatVector || | ||
| field.DataType == entity.FieldTypeBinaryVector || | ||
| field.DataType == entity.FieldTypeBFloat16Vector || | ||
| field.DataType == entity.FieldTypeFloat16Vector { |
There was a problem hiding this comment.
NIT: maybe change to utility function later
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: milvus-io/milvus#22837